feat(core): DEVEXP-1178 Refactor-Base-Models#165
Open
marcos-sinch wants to merge 4 commits into
Open
Conversation
marcos-sinch
requested review from
Hurus111,
JPPortier,
asein-sinch,
edu-sinch and
matsk-sinch
as code owners
marcos-sinch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor base models into core
Consolidates the duplicated per-domain
BaseModelConfigurationclasses (SMS,Numbers, Number Lookup, Conversation) into three shared base classes under
sinch.core.models.internal.BaseConfigModel,SnakeCaseExtrasModel(camelCase→snake_caseextras on validation), and
CamelCaseDumpModel(snake_case→camelCase on dumpwhen
by_alias=True) each domain now aliases to the appropriate base.model_dumpoverride is reimplemented as a Pydantic v2 wrapserializer, so the camelCase rewrite now applies to
model_dump_jsontoo.